From: Jonas Dreßler <verdre@v0yd.nl>
Date: Sun, 22 Sep 2019 11:31:02 +0000 (+0200)
Subject: slider: Unset signal IDs when ending the slider drag
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~811^2^2~25
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=2156577333fd96514888a8f2f825a14ab05b614a;p=gnome-shell.git

slider: Unset signal IDs when ending the slider drag

Unset the signal IDs we connected to when starting the drag. Otherwise
we get error messages if a touch drag is ended after a mouse drag
happened because the signal IDs are still set but no signals are
connected.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/740
---

diff --git a/js/ui/slider.js b/js/ui/slider.js
index 3e35dbcb2..662716d67 100644
--- a/js/ui/slider.js
+++ b/js/ui/slider.js
@@ -100,10 +100,15 @@ var Slider = GObject.registerClass({
 
     _endDragging() {
         if (this._dragging) {
-            if (this._releaseId)
+            if (this._releaseId) {
                 this.disconnect(this._releaseId);
-            if (this._motionId)
+                this._releaseId = 0;
+            }
+
+            if (this._motionId) {
                 this.disconnect(this._motionId);
+                this._motionId = 0;
+            }
 
             if (this._grabbedSequence != null)
                 this._grabbedDevice.sequence_ungrab(this._grabbedSequence);